Temporary fix for Chrome's problem with rendering mask images #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
fix-chrome-mask
branch
from
f285375
to
24465c5
Compare
7 tasks
virajsanghvi
approved these changes
Sep 25, 2024
|
Note: there is a test failure, although looks unrelated |
Signed-off-by: Miki <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Miki <[email protected]> (cherry picked from commit 533c1ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
virajsanghvi
pushed a commit
that referenced
this pull request
Sep 26, 2024
…#1420) Signed-off-by: Miki <[email protected]> (cherry picked from commit 533c1ff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporary fix for Chrome's problem with rendering mask images.
OUI provides the mask-image which Chrome 129 fails to render correctly.
It is not known if or when Chrome will fix this. Since almost all of these classes
are applied to elements with scrollbars where their content contained, containing the
paint is a safe solution.
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.